Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 12 ci build-test #7095

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Aug 13, 2024

I'd recommend removing this node 12 test for the following reasons:

  • newer versions of i.e. Jasmine, node-polyfill-webpack-plugin and others have sunset node 12, keeping this repo with deprecated deps like [email protected] in perpetuity. It's effectively impossible to move the tooling of this repo forward with this limitation.
  • it's effectively only affecting maintainers, since users won't have to make a build of plotly, but just consume one, which is dependant only on the compile output rather which runtime is used for development of plotly.js
  • usage of node 12 should be discourage due to security reasons, having no active nor security support for a long time.
Screenshot 2024-08-13 at 16 42 35

@archmoj
Copy link
Contributor

archmoj commented Aug 13, 2024

Please add draftlogs/7095_change.md file.
Thanks for the PR.

draftlogs/7095_change.md Outdated Show resolved Hide resolved
@birkskyum birkskyum force-pushed the remove-node-12-test branch from 52a5ee7 to fec6a0e Compare August 13, 2024 15:08
Update draftlogs/7095_change.md

Co-authored-by: Mojtaba Samimi <[email protected]>

newline
@birkskyum birkskyum force-pushed the remove-node-12-test branch from fec6a0e to d882d9b Compare August 13, 2024 15:09
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants