Thanks for your interest in plotly.js!
- Please @ mention a few other speakers of this language who can help review your translations.
- If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
- You should only update files in
lib/locales/
, not those indist/
Before opening a pull request, developer should:
- make sure they are not on the
master
branch of their fork as usingmaster
for a pull request would make it difficult to fetchupstream
changes. - fetch latest changes from
upstream/master
into your fork i.e.origin/master
then pullorigin/master
from you localmaster
. - then
git rebase master
their local dev branch off the latestmaster
which should be sync withupstream/master
at this time. - make sure to not
git add
thedist/
folder (thedist/
is updated only on version bumps). - make sure to commit changes to the
package-lock.json
file (if any new dependency required). - provide a title and write an overview of what the PR attempts to do with a link to the issue they are trying to address.
- select the Allow edits from maintainers option (see this article for more details).
After opening a pull request, developer:
- should create a new small markdown log file using the PR number e.g.
1010_fix.md
or1010_add.md
insidedraftlogs
folder as described in this README, commit it and push. - should not force push (i.e.
git push -f
) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please fetchupstream/master
and "merge" with master instead of "rebase".