Error during upgrade

[Gagaro]

During catalog_setup, traceback is as following:

Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.GenericSetup.tool, line 893, in manage_doUpgrades
  Module Products.GenericSetup.upgrade, line 140, in doStep
  Module adria.rcse.upgrades, line 45, in common
  Module adria.rcse.upgrades, line 32, in quickinstall_addons
  Module Products.CMFPlone.QuickInstallerTool, line 101, in upgradeProduct
  Module Products.GenericSetup.upgrade, line 140, in doStep
  Module collective.portlet.favoriting.upgrades, line 7, in common
  Module Products.GenericSetup.tool, line 350, in runAllImportStepsFromProfile
   - __traceback_info__: profile-collective.portlet.favoriting:default
  Module Products.GenericSetup.tool, line 1100, in _runImportStepsFromContext
  Module Products.GenericSetup.tool, line 1015, in _doRunImportStep
   - __traceback_info__: plone.app.event-catalog
  Module plone.app.event.setuphandlers, line 45, in catalog_setup
  Module Products.CMFCore.utils, line 10, in check_getToolByName
  Module Products.CMFCore.utils, line 120, in getToolByName
AttributeError: portal_catalog

[thet]

please give more context on the error:

• which Plone version,
• which plone.app.event version.
• buildout config
• install config (zcml, metadata.xml)

[Gagaro]

Hi thet,

• plone 4.3
• last commit from github - plone5 branch

it's quite a big project, you can see the metadata.xml file there:

https://github.com/collective/collective.rcse/blob/master/collective/rcse/profiles/default/metadata.xml

And the main zcml there:

https://github.com/collective/collective.rcse/blob/master/collective/rcse/configure.zcml

Also I did a bit more testing, catalog_setup() is not called from setup_misc() and site in catalog_setup is:

<Products.GenericSetup.context.DirectoryImportContext object at 0x7fa22c691b50>

I'll keep digging.

[Gagaro]

I don't k now why but the handler for the import step 'plone.app.event catalog setup' is changed at some point:

plone.app.event catalog setup => plone.app.event.setuphandlers.catalog_setup

The handler is correct during the initial registerStep.

[Gagaro]

Actually I am on the plone5 branch.

[Gagaro]

I found something new. in the getSortedImportSteps of the SetupTool (Products.GenericSetup.tool), plone.app.event-catalog is in both global and non-global steps. The global one is the good one but the tool checks on the local one first. I don't know yet why it behaves like that.

[Gagaro]

The manage tab of portal_setup in the ZMI helped med solved it. It told me there was a conflict for this step. So problem solved I guess.

[davisagli]

We need to solve this for other installations of plone.app.event too. Sorry, I thought that portal_setup automatically cleaned up the persistent step when you switch from registering the step in the profile to registering it in ZCML.