Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkintegrity test fails randomly on jenkins.plone.org #854

Closed
tisto opened this issue Sep 2, 2015 · 10 comments
Closed

Linkintegrity test fails randomly on jenkins.plone.org #854

tisto opened this issue Sep 2, 2015 · 10 comments
Assignees
Milestone

Comments

@tisto
Copy link
Member

tisto commented Sep 2, 2015

http://jenkins.plone.org/job/plone-5.0-python-2.7-robot/2255/robot/report/robot_log.html#s1-s15-t3

cc @pbauer

@tisto tisto added this to the Plone 5.0 milestone Sep 2, 2015
@pbauer pbauer self-assigned this Sep 2, 2015
@pbauer
Copy link
Member

pbauer commented Sep 2, 2015

@tisto I'll fix it

@pbauer
Copy link
Member

pbauer commented Sep 2, 2015

Fixed in 1b50bd3

@pbauer pbauer closed this as completed Sep 2, 2015
@tisto
Copy link
Member Author

tisto commented Sep 3, 2015

@tisto tisto reopened this Sep 3, 2015
@pbauer
Copy link
Member

pbauer commented Sep 4, 2015

Fixed in 6d466db

@pbauer pbauer closed this as completed Sep 4, 2015
@tisto
Copy link
Member Author

tisto commented Sep 6, 2015

@tisto tisto reopened this Sep 6, 2015
@pbauer
Copy link
Member

pbauer commented Sep 6, 2015

@tisto I have no clue how that can fail. After Wait Until Page Contains Element css=.pattern-relateditems-result-select.selectable there should not be a problem clicking the same element with Click Link css=.pattern-relateditems-result-select.selectable. Ideas?

@tisto
Copy link
Member Author

tisto commented Sep 7, 2015

@pbauer the element could not be visible (then you need to use "wait until element is visible", sometimes other html elements have a higher z-index so the underlying element can not be clicked. "Wait until page contains" just makes sure the element is there, not that the page is fully loaded and the javascript code has been fully executed. It is also quite common that the underlying JS implementation itself is fragile. Selenium can't fix that then...

@pbauer
Copy link
Member

pbauer commented Sep 7, 2015

@tisto thanks for the tip

@pbauer
Copy link
Member

pbauer commented Sep 8, 2015

I think I finally fixed the test for good in e409071

The main problem was that css=.pattern-relateditems-result-select.selectable (linkable items) existed multiple times before entering Foo and only once afterwards. So the Wait until element is visible caught one from the initial list that disappeared before clicking due to the entered text. Now I wait until the result is exactly what I need using Wait until element is visible jquery=.select2-highlighted .pattern-relateditems-result-select.selectable:contains(Foo).
By the way: the jquery-selector is awesome. Much easier to write that xpath or css.

@pbauer pbauer closed this as completed Sep 8, 2015
@mauritsvanrees
Copy link
Member

Awesome! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants