Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content rules javascript broken on plone 5 #279

Closed
vangheem opened this issue Oct 17, 2014 · 0 comments
Closed

content rules javascript broken on plone 5 #279

vangheem opened this issue Oct 17, 2014 · 0 comments

Comments

@vangheem
Copy link
Member

For this to be fixed, you'll need to review what is implement in https://github.com/plone/plone.app.contentrules/blob/master/plone/app/contentrules/browser/contentrule-elements.js

First off,

test if wrapping the whole call in a::

  'jquery'
], function($) {
  'use strict';

will fix this.

If you need to split off into using patterns:

Parts:

  • move prepOverlay calls into class="pat-modal" and data-pat-modal="{{configuration}}"
  • create new pattern for submitting and serializing a form on a click action
@davisagli davisagli mentioned this issue Oct 17, 2014
90 tasks
@vangheem vangheem closed this as completed Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants