You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the user closes the challenge modal, there are no ways to communicate to the hooks that the user abandoned publishing, and mark the pending account comment as failed immediately, with an appropriate comment.reason.
a function like abandon or stop should be added. if the user closes the modal, it can be called, and the account comment can be changed to failed and a comment.reason can be added.
it might be annoying for the user to display all the failed comments in the UI, so a hook to delete the account comments could be added, and the user could click "X" to delete the failed comment using the hook.
The text was updated successfully, but these errors were encountered:
I thought of an easy way to implement deleting a pending/failed comment. there could be a hook called deleteComment() and it would mark the comment as accountComment.accountDeleted = true
and the frontend could simply hide or filter accountComment.accountDeleted: true comments
I dont think we can just remove account comments from the array, it's too complicated of a design. we also cant just call it accountComment.deleted because that's a protocol field, it means the comment was deleted by the author at the protocol/network level, whereas in our case we're just trying to remove a comment from the local db, or hide it from the user's view
The current API for publishing is:
If the user closes the challenge modal, there are no ways to communicate to the hooks that the user abandoned publishing, and mark the pending account comment as failed immediately, with an appropriate comment.reason.
a function like
abandon
orstop
should be added. if the user closes the modal, it can be called, and the account comment can be changed to failed and a comment.reason can be added.it might be annoying for the user to display all the failed comments in the UI, so a hook to delete the account comments could be added, and the user could click "X" to delete the failed comment using the hook.
The text was updated successfully, but these errors were encountered: