Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Java8 Date/Time Binder Support #1320

Merged
merged 3 commits into from
Nov 29, 2019

Conversation

maicaballangan
Copy link

@maicaballangan maicaballangan commented Nov 6, 2019

Pull Request Checklist

Helpful things

Fixes

  • Add LocalDate and LocalTime Binder
  • Add LocalDate and LocalDateTime InFutureCheck

Purpose

  • Java 8 Date/Time Binder Support

Background Context

N/A

References

N/A

maica added 2 commits November 6, 2019 22:15
* Add LocalDate and LocalDateTime InFutureCheck
@asolntsev
Copy link
Contributor

@maicanotfound Looks good, thank you. Could you also add unit-tests for Local*Binder classes?

@maicaballangan
Copy link
Author

maicaballangan commented Nov 17, 2019

Hi! Added LocalDate and LocalTime Binder Tests

@asolntsev
Copy link
Contributor

@xael-fry Recommended to merge.

@asolntsev asolntsev self-requested a review November 17, 2019 15:59
@xael-fry xael-fry added this to the 1.5.4 milestone Nov 29, 2019
@xael-fry xael-fry merged commit 0f24ed1 into playframework:master Nov 29, 2019
@xael-fry
Copy link
Member

Merged thanks @maicanotfound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants