1197 support non-static dependencies #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xael-fry
previously requested changes
Oct 17, 2017
|
@xael-fry Sure, I will add documentation and tests. |
|
@xael-fry I have made the requested changes. Can you review again? P.S. What did you mean in "As you merged #2138"? What does this number mean? And what documentation should I add? |
asolntsev
dismissed
xael-fry’s stale review
done (except documentation for #2138)
asolntsev
force-pushed
the
use-dependency-injection
branch
from
3b3bc96 to
3404448
Compare
in * jobs * plugins (after reloading plugins) * controllers * CookieSessionStore
asolntsev
force-pushed
the
use-dependency-injection
branch
from
3404448 to
fcabd0a
Compare
xael-fry
approved these changes
Aug 24, 2018
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in