Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -parameters compiler option instead of enhancing classes #1043

Closed
asolntsev opened this issue Dec 17, 2016 · 2 comments
Closed

Use -parameters compiler option instead of enhancing classes #1043

asolntsev opened this issue Dec 17, 2016 · 2 comments
Labels
has-pr improvement
Milestone
1.5.0

Comments

@asolntsev
Copy link
Contributor

After upgrading to Java 8 we can simplify Play compilation/classloading mechanism.

Namely, Java 8 reflection allows to get names of parameters for any method.
Currently Play has a LocalvariablesNamesEnhancer that has to enhance classes, adding special "hidden" fields containing names of parameters for every method. Now this rocket science can be simplified. :)

We just need to upgrade to Java 8. Let's do it!
@asolntsev asolntsev mentioned this issue Jan 9, 2017
Closed
@asolntsev
Copy link
Contributor Author

Pull request #1084 solves this issue.

@asolntsev
Copy link
Contributor Author

Implemented in play 1.5.0 (in master branch)

@xael-fry xael-fry added this to the 1.5.0 milestone Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has-pr improvement
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@asolntsev @xael-fry