Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubemap quality bug in IE11 #1798

Closed
jinwoobot opened this issue Jan 2, 2020 · 3 comments
Closed

Cubemap quality bug in IE11 #1798

jinwoobot opened this issue Jan 2, 2020 · 3 comments
Assignees
Labels
area: graphics Graphics related issue bug

Comments

@jinwoobot
Copy link
Contributor

This article what i wrote on forum
https://forum.playcanvas.com/t/ie11-webgl1-cubemap-is-strange-engine/11683/3

Description

I’ve just tried setting on cubemap (engine code).
It works fine on chrome and Edge browsers but it doesn’t work as my expectation in IE 11.

Steps to Reproduce

  1. Clone https://github.com/velbi/cubemap-test
  2. Add some server (I just use yarn add live-server)
@willeastcott willeastcott added the area: graphics Graphics related issue label Apr 15, 2020
@willeastcott
Copy link
Contributor

I believe this is because your app has app.scene.skyboxMip set to 0. In this case, the skybox is rendered using the PNG cubemap faces (whereas if app.scene.skyboxMip is set to 1 or more, it uses the DDS image data). IE11 has a bug where it will premultiply the RGB data by A and then it is divided away when the texture is used and this causes precision loss and hence the banding. Hey, @slimbuck - did I get that right? Is it worth keeping this issue open (since it's not technically a PlayCanvas bug). Or do you hope we can devise a workaround to this where we no longer rely on PNG format for holding RGBM data?

@slimbuck
Copy link
Member

slimbuck commented Nov 6, 2020

That's exactly right @willeastcott. I think it's worth keeping this ticket around because it this this also still a problem on iOS and we should find a workaround.

@willeastcott
Copy link
Contributor

The new RGBP format (introduced by @slimbuck) should resolve this. Also, the iOS issue @slimbuck references above is now resolved (see #1930). Plus, with the vanishingly small userbase of IE11 these days, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

No branches or pull requests

3 participants