Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe only #309

Closed
wants to merge 2 commits into from
Closed

Describe only #309

wants to merge 2 commits into from

Conversation

airportyh
Copy link

It's holiday season and tis the time to give, thus this pull request.

This is a mod of @vojtajina's ddescribe/iit pull request (#181)

The difference is I've renamed ddescribe to describe.only and iit to it.only, following Mocha's syntax. Tests are included. My hope is that this has a higher chance of getting merged in given that

  1. it has prior art: see Mocha.
  2. it does not introduce any additional globals.

Cheers!

vojtajina and others added 2 commits March 4, 2012 22:34
ddescribe runs only these exclusive suties
iit runs only these exclusive specs
@vojtajina
Copy link

Way to go @airportyh! Thanks!

I talked to pivotal guys couple of months ago and I thought they were sort of getting warmed on this idea, once we showed them our workflow... So I hope, this will get in.

Btw, I still prefer the iit and ddescribe rather than mocha's .only :-D

@airportyh
Copy link
Author

That's hopeful! Let's keep our fingers crossed :)

@IgorMinar
Copy link

one of the reasons why I picked "ddescribe" and "iit" names back in 2010 (yes I've been using this feature for that long) is that it requires typing just one character to switch into the "exclusive" mode. So selecting 4 specs to be exclusively executed is very fast. 1 character also rarely interferes with line wrapping rules, so you get to see the whole description without scrollbars if you have multiple windows open in your editor/ide side by side.

thanks for the alternative approach though. while I'm not in favor of this syntax, I'm glad that you recognize the value of the exclusive mode.

@airportyh
Copy link
Author

@IgorMinar I have no beef with the syntax, I am only trying help get this feature merged in.

@IgorMinar
Copy link

right, but should be easy to use so that not just the feature but also the workflow is preserved. thanks again for trying to push this forward

@vizio360
Copy link

Any news about this pull request? It would be nice to get it in asap.

@svizzari
Copy link

👍 Whatever syntactic style is applied, this would be a fantastic feature to merge, right?

@davidlinse
Copy link

+1

@davemo
Copy link

davemo commented Jul 10, 2013

+1 for this getting merged, this is a useful feature regardless of the semantics.

@davemo
Copy link

davemo commented Jul 10, 2013

Perhaps the lack of response from @pivotal here is an indication this type of functionality isn't appropriate (for whatever reason) to merge into jasmine proper? Regardless of the reason, perhaps this feature could be extracted to a standalone plugin that end-users can just add alongside jasmine kind of like jasmine-stealth, jasmine-given and jasmine-fixture from @searls.

Thoughts @airportyh ?

@davidlinse
Copy link

+1 for either of these..
On Jul 10, 2013 10:41 PM, "David Mosher" [email protected] wrote:

Perhaps the lack of response from @pivotal https://github.com/pivotalhere is an indication this type of functionality isn't appropriate (for
whatever reason) to merge into jasmine proper? Regardless of the reason,
perhaps this feature could be extracted to a standalone plugin that
end-users can just add alongside jasmine kind of like jasmine-stealthhttps://github.com/searls/jasmine-stealth,
jasmine-given https://github.com/searls/jasmine-given and
jasmine-fixture https://github.com/searls/jasmine-fixture from @searlshttps://github.com/searls.

Thoughts @airportyh https://github.com/airportyh ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/309#issuecomment-20771525
.

@airportyh
Copy link
Author

@davemo yeah, that's a good idea. I wouldn't mind making that.

@davemo
Copy link

davemo commented Jul 11, 2013

I started something earlier today @airportyh, https://github.com/davemo/jasmine-only, just basically pulled your code into a lineman-lib template app and got a failing test so far. If you have any ideas or want to collaborate fork away! @searls thinks it would be a good idea to investigate modifying the Runner instead of touching pieces of Spec, Suite and jasmine.Env so I will probably investigate that tonight.

@airportyh
Copy link
Author

@davemo that's awesome! Code away! I'll be heads down with something else until middle of next week, but I'd be glad to help if still needed.

@davemo
Copy link

davemo commented Jul 11, 2013

@airportyh sounds good, I'll see how far I can get :)

@davemo
Copy link

davemo commented Jul 11, 2013

Here's my first attempt at a standalone plugin, travis is still spinning up workers to run the build but it's available and tests are passing. If you have any suggestions on code improvements, please let me know @airportyh, I used most of your code as inspiration :)

https://github.com/davemo/jasmine-only

@vojtajina
Copy link

Guys, I talked to Davis (from Jasmine core team) and they are keen on getting this feature into 2.0, I've been asked to start a thread to get all the motivation together:
https://groups.google.com/forum/?fromgroups#!topic/jasmine-js/SDlib9ruSQo

@schickling
Copy link

@vojtajina thanks for that information but unfortunately the feature didn't make into the 2.0 version. iit / ddescribe is also not available anymore. I'm really missing those features...

@slackersoft
Copy link
Member

We've merged an implementation of fit and fdescribe in this commit ba0982d.

genu added a commit to genu/jasmine.github.io that referenced this pull request Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants