Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich tests for foreign key with PREPARE and "Non-Transactional DML" #56365

Closed
Tracked by #55861
YangKeao opened this issue Sep 27, 2024 · 1 comment · Fixed by #56366
Closed
Tracked by #55861

Enrich tests for foreign key with PREPARE and "Non-Transactional DML" #56365

YangKeao opened this issue Sep 27, 2024 · 1 comment · Fixed by #56366
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

We haven't tested the foreign key check with PREPARE and "Non-Transactional DML". We need to check the following things:

  1. When the foreign key check failed, what will happen for the "Non-Transactional DML".
  2. When the foreign key is added, the prepared plan cache should be invalidated.

They should work fine, as the "Non-Transactional DML" will just finish (though part of the DML may success), and the plan cache will always be invalidated if the schema version increased.

@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Sep 27, 2024
@YangKeao
Copy link
Member Author

Maybe we should also consider the situation when the DDL is in a middle-stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant