Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown doesn't wait for async-commit background goroutines to finish #55607

Closed
YangKeao opened this issue Aug 23, 2024 · 0 comments · Fixed by #55608
Closed

Graceful shutdown doesn't wait for async-commit background goroutines to finish #55607

YangKeao opened this issue Aug 23, 2024 · 0 comments · Fixed by #55608
Assignees
@YangKeao
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

Currently, TiDB killed connections before waiting for the async commit background goroutines to finish. It'd be better to try to wait for them before killing connections to eliminate the leaked lock.
@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Aug 23, 2024
@YangKeao YangKeao self-assigned this Aug 23, 2024
@YangKeao YangKeao mentioned this issue Aug 23, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in cd33d79 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YangKeao YangKeao

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: add hooks to wait for background commit goroutines YangKeao/tidb
1 participant
@YangKeao