Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unnecessary vendor lint after make check #1778

Closed
overvenus opened this issue Sep 29, 2016 · 8 comments
Closed

Add unnecessary vendor lint after make check #1778

overvenus opened this issue Sep 29, 2016 · 8 comments

Comments

@overvenus
Copy link
Member

After including _vendor/src to GOPATH, we may add unnecessary vendor lint after make check if there is no lint present.

neil:tidb/ (master*) $ gst                                                                                                             [12:21:18]
On branch master
Your branch is up-to-date with 'upstream/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    _vendor/pkg/
    _vendor/src/github.com/golang/lint/

no changes added to commit (use "git add" and/or "git commit -a")

ref: #1748

/cc: @tiancaiamao

@overvenus
Copy link
Member Author

I think .gitignore is the quickest solution.

@overvenus
Copy link
Member Author

make install may fails too.

@tiancaiamao
Copy link
Contributor

let go get github.com/golang/lint/golint use the origin GOPATH ?
@shenli

@tiancaiamao
Copy link
Contributor

make install can be removed, I think

@tiancaiamao
Copy link
Contributor

and @coocood , what's your option?

@coocood
Copy link
Member

coocood commented Sep 29, 2016

go get golint use origin GOPATH is better.

@overvenus
Copy link
Member Author

Not only golint. Glide, errcheck and anything relate to go (get|build|install) may be affected.

@overvenus
Copy link
Member Author

close via #1782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants