Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the router implementation using routing #318

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Jun 18, 2019

This PR includes:

  • Implement routing library
  • Translate 'Refresh'
  • Simplify KodiWrapper and VRTPlayer constructors
  • Remove router class

This fixes #103

@dagwieers dagwieers added the enhancement New feature or request label Jun 18, 2019
@dagwieers dagwieers added this to the v2.0.0 milestone Jun 18, 2019
@dagwieers dagwieers force-pushed the routing branch 6 times, most recently from 2584b9f to 17c4df9 Compare June 18, 2019 01:50
This PR includes:
- Implement routing library
- Translate 'Refresh'
- Simplify KodiWrapper and VRTPlayer constructors
- Remove router class
@dagwieers dagwieers changed the title WIP: Improve the router implementation using routing Improve the router implementation using routing Jun 18, 2019
@dagwieers
Copy link
Collaborator Author

So I am sure we can still improve this. (e.g. I would like to use the plugin.url_for() mechanism for constructing paths). But this already works pretty well and in my observation some menus are faster to load too.

@dagwieers dagwieers merged commit bc198f4 into add-ons:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to using script.module.routing
1 participant