Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower quality stream/ ISP limits #172

Closed
vasonline opened this issue May 2, 2019 · 12 comments · Fixed by #189
Closed

Lower quality stream/ ISP limits #172

vasonline opened this issue May 2, 2019 · 12 comments · Fixed by #189
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@vasonline
Copy link

vasonline commented May 2, 2019

Describe the bug

Might not be a bug with the addon...

Situation: went over download budget with ISP.
Download speed is now limited to ~100kB/s

Videostream from addon play for 2 sec, then buffers, then plays 2 sec.
Clearly the restricted bandwidth is playing a role here.
! no fault of the addon.

However VRT website does something different. When playing livestream
or using on demand it switches to a lower quality stream.
Playback then functions normal (no more buffer empty) at a lower quality.

I do not know, maybe the addon can implement something similar if it notices
the bandwidth is not sufficient?
A sort of auto fallback?

Greetings:

ps @dagwiers: Your EPG is great. MUCH better to use with the Kodi
remote.

@dagwieers dagwieers added help wanted Extra attention is needed question Further information is requested labels May 2, 2019
@dagwieers
Copy link
Collaborator

@vasonline I will put it on the Ideas Wiki page, but leave it to others to see if this is feasible (either by auto-sensing or by specifying a bandwidth limit).

@dagwieers dagwieers added bug Something isn't working and removed help wanted Extra attention is needed labels May 2, 2019
@mediaminister
Copy link
Collaborator

mediaminister commented May 2, 2019

You can also solve this issue immediately by changing ISPs. In my humble opinion, this is the best solution if you use internet streaming to watch VRT on your TV set.

This function is called "adaptive bitrate switching" and this is not yet activated in inputstream.adaptive, the module Kodi uses for streaming. It will take some time to investigate and write code to get this working properly.

In the coming weeks I'll investigate how to implement a temporary fix with a user setting in our own addon.

@dagwieers
Copy link
Collaborator

Given the fact how well Kodi works on Android, being able to limit the bandwidth would be useful for using the VRT NU addon on mobile networks too.

@vasonline
Copy link
Author

Hi,

@mediaminister: interesting read on link!

  • Could be benefical too for a faster first load of the stream

@dagwiers:
Yes, mobile could a good reason too.

@dagwieers dagwieers added enhancement New feature or request and removed bug Something isn't working labels May 3, 2019
@mediaminister
Copy link
Collaborator

I have a first simple fix. When you disable the DRM setting in our add-on and disable the add-on inputstream.adaptive, you can use the Kodi bandwidth setting in System > Internet access > Internet connection bandwidth limitation again.
Pull request: #182
Zip:
plugin.video.vrt.nu-1.8.0-fc47ace.zip

@dagwieers
Copy link
Collaborator

dagwieers commented May 4, 2019

@mediaminister It would be nice if our own HTTP code (urllib/urllib2) would adhere the Kodi's bandwidth limitation as well (just as we could make inputstream.adaptive adhere to it too). Not a real priority.

But I would prefer if we would make stream selection something different from bandwidth limitation in the long run, as they play at different levels in the stack. Obviously, setting a bandwidth-limitation would influence stream selection as well (lowest of both).

@dagwieers dagwieers added this to the Future milestone May 4, 2019
@mediaminister
Copy link
Collaborator

mediaminister commented May 4, 2019

@vasonline: I found out inputstream.adaptive has also a bandwidth limitation setting in their add-on settings. So, it's possible to solve your problem by manually configuring a couple of settings.

So, while there is no automatic bitrate switching yet, you can do this manually.

@dagwieers Can you reconsider merging my pull request because automatic bitrate switching should be fixed upstream.

@dagwieers
Copy link
Collaborator

dagwieers commented May 6, 2019

@vasonline We added 2 changes to the master branch that will affect your use-case positively. You can now set the max bandwidth the plugin should be using. Or you can set the global Kodi bandwidth limiting setting, both will affect our plugin (it will take the lowest limit of both settings).

Please test and report back ! (Instructions to testing the master branch)

@dagwieers
Copy link
Collaborator

I added information related to these settings to our Wiki at: https://github.com/pietje666/plugin.video.vrt.nu/wiki/Bandwidth

@vasonline
Copy link
Author

@Dagwiers:
Just went away a few days, and saw all the amazing work!

Will download the latest branch and test on our AndroidTV device.

@vasonline
Copy link
Author

Update: works fine on our Android TV device.
Tested the different bandwidth settings and that worked perfectly.
You can easily see the different PQ quality on screen.

@dagwieers
Copy link
Collaborator

@vasonline Thanks for the feedback. Also thanks to @mediaminister to fix it for the HLS streams.

@dagwieers dagwieers modified the milestones: Future, v1.10.0 May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants