Add Radio support #162
Add Radio support #162
Conversation
dagwieers
force-pushed
the
radio-support
branch
from
2f0f7dc to
c3e2c1a
Compare
dagwieers
force-pushed
the
radio-support
branch
11 times, most recently
from
4df1292 to
7b97d8f
Compare
dagwieers
force-pushed
the
radio-support
branch
4 times, most recently
from
c716d72 to
34abc4f
Compare
|
Ideas for the future:
|
|
Yes indeed a separate addon would be alot better imo |
|
It currently acts as 2 addons, have you tried it? |
|
No i did not, was looking into it now how do is pass content type as a param? because it still uses the same addon.py right and same logo etc? Did not look into detail |
|
I'm not against this when VRT integrates audio into VRT NU. But VRT NU is a video service. |
|
Ok, I was torn. We already include non VRT NU services (like the live streams) and the Radio streams are exactly like the live streams. So if we wanted to do this we may have wanted to rename the addon to just "VRT" instead. But having both the same addon for Video and Music with the same name and logo could be confusing. If we were going to do this, I would have probably added shortcuts from TV to Radio and back. (Something we could still do from the Settings, so people can easily install one from the other) But I liked the fact that the PR was so simple and clean, and we reuse the same CHANNELS database as there is some overlap (e.g. we do have Radio-related video streams etc.). |
|
So welcome to plugin.audio.vrt.radio :-) |
A central database of all channels is very useful, and opens up the possibility to fall back when web scraping fails. It also makes it possible to start adding audio streams, or studio translations.
As a work-in-progress, I also added Radio stream support as a separate Music addon. I know we already discussed we did not want this in this addon, and it is quite easy to separate this from the other code into a completely different project if needed. (Probably because we want to do this under a different name?)