Add an action to check your credentials from the add-on settings. #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to postpone this to v2.0.1 or v2.1.0 (whatever comes first). |
|
This should definitely be postponed because #351 is maybe not fully valid. |
|
Sure, I wasn't aiming at the 2.0 release |
|
I tested it yesterday and it works fine. I am even inclined to remove the automatic clearing of the password when authentication fails. It would also be nice if there was an option to show the password (even if temporarily). |
|
So will the next version be v2.0.1 or v2.1.0 ? :-) |
|
@dagwieers, i would prefer if the password won't reset. I had a typo in my username and it was a bit strange that my password was cleared :) |
|
@michaelarnauts Exactly my point :-) Do you want to make a PR for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
This adds a function to
tokenresolver.pyto just check the tokens. I couldn't reuse an existing function since they look in cache first. The credentials tab in the settings has an action now to run this function that checks the login credentials. A message is displayed indicating success or failure, and the settings dialog is shown again.Note that I had to add
option="close"to the settings since Kodi only saves the settings when the dialog is closed.I also added
*.pyoto the.gitignorefile. Kodi creates these compiled files.