Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking credentials from an action in the settings xml #351

Closed
michaelarnauts opened this issue Jun 30, 2019 · 4 comments · Fixed by #352
Closed

Allow checking credentials from an action in the settings xml #351

michaelarnauts opened this issue Jun 30, 2019 · 4 comments · Fixed by #352
Labels
enhancement New feature or request
Milestone

Comments

@michaelarnauts
Copy link
Contributor

When configuring the addon, but you are not sure what your credentials are. The current flow is as follows:

  • Go to settings and fill in your username and password.
  • Save
  • Open addon, go to A-Z, select a program and try to play it.
  • An error occurs, start again.

We can use the action type in the settings xml to run an action that checks the credentials, and show a message if it failed or was successful.

I'm willing to create a PR for this, as an attempt to get to know the codebase a bit :)

@mediaminister
Copy link
Collaborator

mediaminister commented Jun 30, 2019

I can't reproduce this issue. Maybe you get an error because A-Z and sub categories listing in the current master branch is broken due to an issue with unicode and urllib2.quote

I fixed the broken master branch, but my pull request is not yet merged: https://github.com/pietje666/plugin.video.vrt.nu/pull/350/files

Login errors are handled already: https://github.com/pietje666/plugin.video.vrt.nu/blob/79644c7889f3a468cba7d3e09c83d639d2c51668/resources/lib/tokenresolver.py#L237

@dagwieers
Copy link
Collaborator

dagwieers commented Jun 30, 2019

@mediaminister I am going to merge your PR now, thanks for bringing quote_plus() to the foreground :-)

@dagwieers dagwieers added the enhancement New feature or request label Jun 30, 2019
@dagwieers dagwieers added this to the Future milestone Jun 30, 2019
@michaelarnauts
Copy link
Contributor Author

Sure, errors are handled fine. It's just there is no way to check your credentials at the place where you fill them in. When you are not sure about your password, you need quite some clicking around to give it a few tries.

@dagwieers
Copy link
Collaborator

dagwieers commented Jun 30, 2019

@michaelarnauts I agree. But we are about to release v2.0.0 and I don't want to spend more time testing your implementation for this release. Just saw your reply on the PR :-)

@dagwieers dagwieers modified the milestones: Future, v2.1.0 Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants