-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow checking credentials from an action in the settings xml #351
Comments
I can't reproduce this issue. Maybe you get an error because A-Z and sub categories listing in the current master branch is broken due to an issue with unicode and urllib2.quote I fixed the broken master branch, but my pull request is not yet merged: https://github.com/pietje666/plugin.video.vrt.nu/pull/350/files Login errors are handled already: https://github.com/pietje666/plugin.video.vrt.nu/blob/79644c7889f3a468cba7d3e09c83d639d2c51668/resources/lib/tokenresolver.py#L237 |
@mediaminister I am going to merge your PR now, thanks for bringing quote_plus() to the foreground :-) |
Sure, errors are handled fine. It's just there is no way to check your credentials at the place where you fill them in. When you are not sure about your password, you need quite some clicking around to give it a few tries. |
@michaelarnauts I agree. |
When configuring the addon, but you are not sure what your credentials are. The current flow is as follows:
We can use the
action
type in the settings xml to run an action that checks the credentials, and show a message if it failed or was successful.I'm willing to create a PR for this, as an attempt to get to know the codebase a bit :)
The text was updated successfully, but these errors were encountered: