Add 'Install Widevine' settings option #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagwieers
force-pushed
the
widevine
branch
2 times, most recently
from
7142213 to
25acc7e
Compare
|
It seems our tests using a date (in this case the offline list) is sensitive to timezones. If CI is running in another timezone, today's date may be Belgium's yesterday. And obviously the offline list will be empty (as we are asking for a list of files that have already been removed). This needs some re-thought, as it means the offline list may not work for people in other timezones correctly. We should always be returning CEST dates... |
This PR enables the (re-)installation of Widevine.
|
So for offline matching I now use the Europe/Brussels timezone, rather than the local timezone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the (re-)installation of Widevine for testing purposes.