Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize settings #190

Merged
merged 1 commit into from
May 7, 2019
Merged

Reorganize settings #190

merged 1 commit into from
May 7, 2019

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented May 6, 2019

This PR implements:

  • Credentials
    • Username
    • Password
  • Video
    • Show subtitles
    • Use DRM
    • Internet bandwidth limitation
  • Interface
    • Permalink in plot
  • VRT Radio
    • Install/run VRT Radio
  • Debug
    • Inputstream Adaptive settings
    • Clear VRT cookies
    • Log level

@dagwieers dagwieers added the enhancement New feature or request label May 6, 2019
@dagwieers dagwieers added this to the v2.0.0 milestone May 6, 2019
@dagwieers dagwieers force-pushed the settings-reorg branch 2 times, most recently from 3511c52 to 31afc28 Compare May 6, 2019 15:16
@mediaminister
Copy link
Collaborator

mediaminister commented May 6, 2019

VRT Radio and Debug settings are useless, everyone who wants to enable these settings or add-ons, can do this in Kodi.
We don't need to duplicate functionality, keep it simple please.

@dagwieers
Copy link
Collaborator Author

dagwieers commented May 6, 2019

@mediaminister The Radio section is to make it easier to find VRT Radio, and I plan to do the same in the VRT Radio plugin. But only if it can both install it (if needed) and run it. (Currently it only runs it).

For Debug I do think it is useful to have this readily available. And both Retrospect as well as Netflix plugin are doing the same. The Log level only affects the plugin log settings, which I think is an important property as well. Kodi's debug logging is too verbose.

@mediaminister
Copy link
Collaborator

mediaminister commented May 6, 2019

  1. You can easily find and install other add-ons through Kodi's search function. I thought we agreed to make VRT Radio a separate project because VRT NU is a video service.
  2. Debug is okay for me, but I think most users will never use the debug option.

@dagwieers
Copy link
Collaborator Author

dagwieers commented May 6, 2019

Things I would like to see in the future as well:

  • Parental
    • Exclusive channel list (limit everything based on channel list)
    • Day/Time settings (only enable plugin between specific times)
  • Debug
    • (Re-)install Widevine
    • Clear tokens
    • Force stream selection (MPEG-DASH/HLS/...) (This may report failure if it is not possible)

@dagwieers
Copy link
Collaborator Author

dagwieers commented May 6, 2019

@mediaminister VRT Radio is a separate project, but I think it is in the user's best interest as well as beneficial to both projects to link to each other as they are both complementary. There are more plugins that do similar things.

@pietje666 What do you think ? If you both object obviously I won't do it, but this is what I would propose.

@dagwieers
Copy link
Collaborator Author

In the longer run I was even thinking to link to other plugins that relate to Flemish (or even Belgian) TV stations. Have a More... tab with Retrospect Belgium, Yelo, and others. But that would be an even more controversial idea ;-)

@dagwieers dagwieers force-pushed the settings-reorg branch 4 times, most recently from e50c7e3 to a876af8 Compare May 7, 2019 17:20
This PR implements:
- **Credentials**
  - Username
  - Password
- **Video**
  - Show subtitles
  - Use DRM
- **Interface**
  - Permalink in plot
- **Debug**
  - Inputstream Adaptive settings
  - Clear VRT cookies
  - Log level
@dagwieers dagwieers merged commit c3206f2 into add-ons:master May 7, 2019
@dagwieers dagwieers modified the milestones: v2.0.0, v1.10.0 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants