-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback for live streams when web scraping fails #168
Conversation
@mediaminister Please test! I tested this by enabling (non-working) stubru and mnm livestreams. And it correctly falls back to using the provided video_id. |
This implements vualto live stream support (by video_id) for streams that do not rely on web scraping, but also implements a fallback mechanism in case web scraping fails. This is the last piece to get rid of any reliance on web scraping. Users everywhere rejoice !
c871ed4
to
393fafd
Compare
I am going to merge this, so I can test everything (including Radio support) in a single build. |
This code can't work. You can't return streamurls before we check roaming, etc... |
@mediaminister OK, this affects only the fallback for the original streams. We can fix this. |
Maybe it affects more than that. I'm testing at the moment. |
No, it worked fine (as a fallback) for the MNM and Studio Brussel streams, and only is used as a fallback for the original streams. So yes, we need to fix this, it definitely fails to fallback. |
We never used web scraping for MNM and Studio Brussel, it never executed your fall back code. |
Well, for testing I added the live URL that obviously fails to be scraped correctly. |
I'll be back later this evening. |
I found out what was wrong and created a fix: #170 |
I wondered what the _geo streams were, apparently they are the solution ;-) |
This implements vualto live stream support (by video_id) for streams
that do not rely on web scraping, but also implements a fallback
mechanism in case web scraping fails.
This is the last piece to get rid of any reliance on web scraping.
Users everywhere rejoice !
This fixes #57