Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Studio Brussel and MNM live streams #166

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

dagwieers
Copy link
Collaborator

These two streams were still on my wishlist.

@dagwieers dagwieers added the enhancement New feature or request label Apr 30, 2019
@dagwieers dagwieers merged commit c643ba6 into add-ons:master Apr 30, 2019
@mediaminister
Copy link
Collaborator

This doesn't work in Kodi 17, because you hardcoded the mpeg_dash streams that are only supported by inputstream.adaptive.

I have a fix for this, you can just provide the livestream video_id and let the streamservice select the right stream.
mediaminister@1642cc1

@dagwieers
Copy link
Collaborator Author

@mediaminister I first looked at scraping the website, but that was a big pile of Javascript junk. I see this as a potential way to fallback from scraping for the VRT TV channels as well. If scraping fails, we could use the last known working link. It still depends on how often that link would change.

@mediaminister
Copy link
Collaborator

We can use the livestream video_id for all channels as a fallback.
But I think using mpeg_dash and hls urls is not a good idea because these urls have changed a couple of times already.

@dagwieers
Copy link
Collaborator Author

@mediaminister Perfect, I am reworking your PR with this in mind. The death to web scraping dependencies !

I wonder whether we need to inform the user when we fall back when web-scraping fails, or whether we just rely on unit tests to inform us?

@mediaminister
Copy link
Collaborator

mediaminister commented May 1, 2019

It's not nice to bother a "normal" user with this. A "normal" user only cares if the stream works. Not why or how it works.

@dagwieers dagwieers added this to the 1.9.0 milestone May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants