Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording in the readme #52

Merged
merged 2 commits into from
Mar 20, 2021
Merged

Conversation

glensc
Copy link

@glensc glensc commented Mar 14, 2021

Make the text more fluent, include the rest of the forking history, include bit about output types, and remove negative emotions from the readme.

@glensc glensc force-pushed the readme-update branch 2 times, most recently from 0b2be13 to 88c8291 Compare March 14, 2021 09:10
Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glensc Thanks for doing this! Looking good.
I've left a few small remarks in-line for you to consider.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
glensc added 2 commits March 15, 2021 11:58
- Update Fork section to be neutral and include current fork relation
- Improve wording in the rest of the readme
- Add git blame as well into readme
@glensc
Copy link
Author

glensc commented Mar 15, 2021

@jrfnl, I've updated based on your suggestions. I may have missed some suggestions, if the GitHub UI didn't show them anymore after the previous suggestion apply.

@glensc
Copy link
Author

glensc commented Mar 15, 2021

In my opinion, it looks beautiful now :)

Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree ;-) These are good improvements.

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 15, 2021

@glensc Thanks for updating the PR!

@grogy grogy merged commit d539e6c into php-parallel-lint:master Mar 20, 2021
@grogy
Copy link
Member

grogy commented Mar 20, 2021

Thank you both, it looks so better 👍

@glensc glensc deleted the readme-update branch March 21, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants