Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP version check at start of file doesn't work #62

Closed
jrfnl opened this issue Jun 8, 2021 · 0 comments · Fixed by #100
Closed

PHP version check at start of file doesn't work #62

jrfnl opened this issue Jun 8, 2021 · 0 comments · Fixed by #100
Assignees
Milestone

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Jun 8, 2021

... as the parallel-lint file in which it is contained contains PHP 5.3 syntax (namespace separators), which means that the code will never run as PHP will exit on a parse error before that time:

Warning: Unexpected character in input:  '\' (ASCII=92) state=1 in path/to/PHP-Parallel-Lint/parallel-lint on line 84
Parse error: syntax error, unexpected T_STRING in path/to/PHP-Parallel-Lint/parallel-lint on line 84
@jrfnl jrfnl added this to the 2.0.0 milestone Feb 19, 2022
@jrfnl jrfnl self-assigned this Feb 20, 2022
@grogy grogy closed this as completed in #100 Mar 3, 2022
@jrfnl jrfnl added the Type: bug label Mar 9, 2022
@jrfnl jrfnl modified the milestones: 2.0.0, 1.4.0 Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant