Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio preference "Customize Voice" should be an AccordionBox. #1001

Open
pixelzoom opened this issue Dec 16, 2024 · 0 comments
Open

Audio preference "Customize Voice" should be an AccordionBox. #1001

pixelzoom opened this issue Dec 16, 2024 · 0 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 16, 2024 •
edited
Loading

From phetsims/sun#919 (comment) ...

The "Customize Voice" preference (implemented in VoicingPanelSection.ts) should be using AccordionBox, not creating its own pseudo-accordion box using ExpandCollapseButton. The screenshot below shows where this appears in Audio preferences (for example in John Travoltage).

voicing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom