Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.10-rc.1-phetio] [State Wrapper] tools not appearing in second iframe #66

Open
JRomero0613 opened this issue Jun 12, 2018 · 4 comments
Labels

Comments

@JRomero0613
Copy link

Test Device: PC Laptop

OS: Windows 10 v. 1803

Browser: Google Chrome v. 67.0.3396.79

Problem description: For phetsims/qa#128 when using the state wrapper with CCKBBS v. 1.0.10-rc.1 (found here https://github.com/phetsims/phet-io/issues/1329#issue-329557833) the copied smaller sim does not show any construction pieces including the battery, wire, resistor, or bulb. Everything else is translated to the smaller sim but not the most important features of the sim.

Screenshot:
cckbbs_state

@ghost
Copy link

ghost commented Jun 12, 2018

In the console when I drag a wire into the play area:


TypeError: Cannot read property 'constructor' of undefined
    at Object.getType (circuit-construction-kit-black-box-study_en-phetio.html?production:934)
    at Object.g [as setState] (circuit-construction-kit-black-box-study_en-phetio.html?production:934)
    at TPhETIO.implementation [as setState] (circuit-construction-kit-black-box-study_en-phetio.html?production:965)
    at Object.invoke (circuit-construction-kit-black-box-study_en-phetio.html?production:965)
    at Object.handleRequest (circuit-construction-kit-black-box-study_en-phetio.html?production:965)
    at circuit-construction-kit-black-box-study_en-phetio.html?production:965

@JRomero0613
Copy link
Author

This same bug occurs in version 1.1.6-rc.1 with this error in the console:


Error: Impossible set state:
circuitConstructionKitBlackBoxStudy.exploreScreen.model.circuit.vertices_0.positionProperty
circuitConstructionKitBlackBoxStudy.exploreScreen.model.circuit.vertices_0.voltageProperty
circuitConstructionKitBlackBoxStudy.exploreScreen.model.circuit.vertices_0.selectedProperty
circuitConstructionKitBlackBoxStudy.exploreScreen.model.circuit.vertices_1.positionProperty
circuitConstructionKitBlackBoxStudy.exploreScreen.model.circuit.vertices_1.voltageProperty
circuitConstructionKitBlackBoxStudy.exploreScreen.model.circuit.vertices_1.selectedProperty
    at circuit-construction-kit-black-box-study_en-phetio.html?production&sim=circuit-construction-kit-black-box-study&relativeSimPath&frameTitle=destination:1002
    at Object.g [as setState] (circuit-construction-kit-black-box-study_en-phetio.html?production&sim=circuit-construction-kit-black-box-study&relativeSimPath&frameTitle=destination:1002)
    at TPhETIO.implementation [as setState] (circuit-construction-kit-black-box-study_en-phetio.html?production&sim=circuit-construction-kit-black-box-study&relativeSimPath&frameTitle=destination:1036)
    at Object.invoke (circuit-construction-kit-black-box-study_en-phetio.html?production&sim=circuit-construction-kit-black-box-study&relativeSimPath&frameTitle=destination:1035)
    at Object.handleRequest (circuit-construction-kit-black-box-study_en-phetio.html?production&sim=circuit-construction-kit-black-box-study&relativeSimPath&frameTitle=destination:1035)
    at circuit-construction-kit-black-box-study_en-phetio.html?production&sim=circuit-construction-kit-black-box-study&relativeSimPath&frameTitle=destination:1035

@ghost ghost changed the title [1.0.10-rc.1-phetio] State Wrapper doesn't transmit properly [1.0.10-rc.1-phetio] [State Wrapper] tools not appearing in second iframe Jun 14, 2018
@zepumph zepumph assigned samreid and unassigned zepumph Jun 28, 2018
@zepumph
Copy link
Member

zepumph commented Jun 28, 2018

Assigning @samreid as lead dev on this sim, but we will not be fixing this for this maintenance release.

@samreid
Copy link
Member

samreid commented Jul 6, 2018

Unassigning until we resume work on this simulation.

@samreid samreid removed their assignment Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants