Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances of MovablePointChargeModel have both position and positionProperty #557

Open
jbphet opened this issue Oct 25, 2021 · 0 comments
Open

Comments

@jbphet
Copy link
Contributor

jbphet commented Oct 25, 2021

While working to resolve a bug reported by QA (#547), I found that instances of MovablePointChargeModel have a property named position and another named positionProperty. The latter is added to the base class PointChargeModel via inheritance. This seems like poor design, and confused me while working on it, and led me to create the aforementioned bug. I don't have the time to fix this at the moment, but the next time any significant work is done on this sim, this should be addressed, either by improving the design or at least the naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant