Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending an existing method in other package does nothing in Calypso browser #17481

Closed
riuttner opened this issue Dec 2, 2024 · 1 comment · Fixed by #17489
Closed

Extending an existing method in other package does nothing in Calypso browser #17481

riuttner opened this issue Dec 2, 2024 · 1 comment · Fixed by #17489

Comments

@riuttner
Copy link
Contributor

riuttner commented Dec 2, 2024

Checking extension box in calypso allows to select package, but when extension is confirmed, nothing happens (P13, W10).
Expected behavior is however:

  • The checkbox stays checked when returning from package selection
  • The name of the extending package is shown left of the checkbox

The expected behavior is broken not longer than since 3 weeks.

How to reproduce it:

  • Browse class Boolean
  • Select method #asBit (which is just implemented as subclassResponsibility in Kernel package)
  • Click checkbox extension, choose an arbitrary package (e.g. Deprecated13)
  • Close package selection dialog with Ok

Nothing happens. Existing extension methods of the same class, however, are displayed correctly.

IMHO this is very urgent: Currently, you cannot extend a class in a package where the class has not yet been extended in. Even my personal "emergency fallback" for cases like that, using file-in, currently does not work without another patch (see #17480)

@jecisc
Copy link
Member

jecisc commented Dec 3, 2024

I got the same problem today. This was working recently so the break is pretty recent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants