Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

Like/dislike bar is very tall #29

Closed
dben89x opened this issue Nov 22, 2021 · 9 comments
Closed

Like/dislike bar is very tall #29

dben89x opened this issue Nov 22, 2021 · 9 comments

Comments

@dben89x
Copy link

dben89x commented Nov 22, 2021

The like/dislike bar stacks 6 of the following elements on top of each other, so that the bar comes out very tall:

<div class="progress" id="test" style="position: relative; height: 3px; width: 40%; background: rgb(205, 205, 205);"><div class="color" id="color" style="position: absolute; background: rgb(6, 95, 212); width: 97.9588%; height: 3px;"></div></div>

Screen Shot 2021-11-22 at 3 06 48 PM

Is this intended? When I manually remove 5 of the 6 elements, it seems to look right.

Below is a screenshot of the 6 stacked elements:

Screen Shot 2021-11-22 at 3 01 02 PM

And below is after removing 5 of the 6 elements:

Screen Shot 2021-11-22 at 3 07 13 PM

@thereaper90917
Copy link
Contributor

are you using the latest release here? that is a known bug from a previous release that got fixed :D

@pgamerx
Copy link
Owner

pgamerx commented Nov 23, 2021

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

@thereaper90917
Copy link
Contributor

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

not sure the id in the screenshot is "test" we changed that to "custom-progress" when we did the fix for the ratio bar repeating itself. iirc

@dben89x
Copy link
Author

dben89x commented Nov 23, 2021

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

This is bizarre. I have 1.6.6 installed on 3 devices.

All devices are running Brave Version 1.32.106 Chromium: 96.0.4664.45 (Official Build) (x86_64)

On two of the three devices, the bar is short. On one of the devices, it's tall. The one device where it's tall is on a MacBook Air. The other two devices (MacBook Pro 15" and Mac Mini with a widescreen monitor) are fine.

I've double checked to make 100% sure that all devices are running the same version of Chromium and the same version of this repo.

Is there anything I should test? I've tried different resolutions in the web inspector on all 3 devices, but nothing changes.

Edit: I'm actually seeing 3 elements stacked now on the MacBook Pro 15". It was just one bar when visiting youtube directly after installing the add-on. Tried a hard refresh, not sure what else I can try.

@Adib-C
Copy link
Contributor

Adib-C commented Nov 23, 2021

I can confirm that the bar is very tall on the 1.6.6 version

@Adib-C
Copy link
Contributor

Adib-C commented Nov 23, 2021

I think there is some conflict with PR #26 and #30 which caused this problem

@pgamerx
Copy link
Owner

pgamerx commented Nov 23, 2021

If I remember correctly, this was fixed in 1.6.6, but nonetheless I will check it.

This is bizarre. I have 1.6.6 installed on 3 devices.

All devices are running Brave Version 1.32.106 Chromium: 96.0.4664.45 (Official Build) (x86_64)

On two of the three devices, the bar is short. On one of the devices, it's tall. The one device where it's tall is on a MacBook Air. The other two devices (MacBook Pro 15" and Mac Mini with a widescreen monitor) are fine.

I've double checked to make 100% sure that all devices are running the same version of Chromium and the same version of this repo.

Is there anything I should test? I've tried different resolutions in the web inspector on all 3 devices, but nothing changes.

Edit: I'm actually seeing 3 elements stacked now on the MacBook Pro 15". It was just one bar when visiting youtube directly after installing the add-on. Tried a hard refresh, not sure what else I can try.

Today I will release v1.6.7, sorry for the issue and this shall be fixed in today's release (chromium only)

@hisRoyalty
Copy link
Contributor

Is this issue fixed? If it is, it should be closed.

@pgamerx
Copy link
Owner

pgamerx commented Nov 24, 2021

@dben89x it has been fixed in 1.7.5 aka latest release, sorry for the issue.

@pgamerx pgamerx closed this as completed Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants