New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "plain" instead of "raw" as suffix in function name to denote plain integers. #8

Open

krashish8 opened this issue Jun 22, 2021 · 1 comment

Labels

Member

krashish8 commented Jun 22, 2021

In the pick Deliver functions, we have both the signatures - to take timestamps as input, and to take plain integers as input.

The function for the plain integers is suffixed with "raw". Changing it to "plain" would be more relevant.

Sample Links:
https://github.com/pgRouting/vrprouting/blob/develop/src/pickDeliver/pickDeliver.c#L64
https://github.com/pgRouting/vrprouting/blob/develop/src/pickDeliver/pickDeliver.c#L97
https://github.com/pgRouting/vrprouting/blob/develop/src/pickDeliver/pickDeliver.c#L246
https://github.com/pgRouting/vrprouting/blob/develop/src/pickDeliver/pickDeliver.c#L352

krashish8 added the enhancement label

Member

cvvergara commented Jun 22, 2021

Right, specially for the SQL functions :-)

krashish8 mentioned this issue

Add vroom category functions with timestamps #14

Merged

9 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment