Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange results near NULL areas #1

Open
lrntct opened this issue Mar 14, 2017 · 5 comments
Open

Strange results near NULL areas #1

lrntct opened this issue Mar 14, 2017 · 5 comments
Assignees

Comments

@lrntct
Copy link

lrntct commented Mar 14, 2017

First of all, thanks for this module, it is just what I needed.
I tried to use it to patch an ALOS DSM with a LiDAR DTM over Acapulco, México.
It seems to work well at the interface of the two maps, inland.
However, on the shore, where the ocean is NULL, the results seems a bit strange:

Here is the ALOS DSM on a small part of the shore:
aw3d30

The LiDAR:
dtm_lidar

The results of
r.patch.smooth -s input_a=dtm_lidar@Acapulco input_b=AW3D30@Acapulco output=AW3D30_lidar transition_angle=1
aw3d30_lidar

It looks like the information of ALOS is passed to the new map, instead of using the LiDAR, and the transition is coarse outside the cape.

@petrasovaa
Copy link
Owner

I think I know what's the problem. I was always working with DEMs where input_a was smaller and completely inside input_b DEM, so I didn't need to handle the edge case, which requires different behavior. I will look into that. Thanks for your interest!

@petrasovaa petrasovaa self-assigned this Mar 15, 2017
@petrasovaa
Copy link
Owner

In 783bc67 I tried to address this issue by adding a new parameter blend_mask where you specify which edges should be excluded from the blending. This problem is actually more difficult to solve than I expected...

@smathermather
Copy link

Hi @petrasovaa -- will this be an issue with blending elevation models overlapping as so?:
image

We are looking to use r.patch.smooth through WebODM for DEM merging for the Split-Merge approach, and I wonder if this is appropriate.

@petrasovaa
Copy link
Owner

R.patch.smooth was designed for little bit different use case (merging UAV dataset into larger lidar data), so I don't think it would work out of the box. However, the method is fairly general, so with some tweaking for this use case, I think it's doable. Could you possibly send me sample data so that I can test the approach?

@smathermather
Copy link

I should have something for you first thing next week. I finally got it processing... .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants