Naming standards

[benjamingr]

Hey, I just wanted to ask why the code does things like: Promise$_all Promise$_All and Promise$all?

Is the naming (lower case/upper case) here an important convention?

Can we rename these to something more meaningful?

[petkaantonov]

ClassName '$' methodName
ClassName '$' StaticMethodName

Underscore at the start of the method marks an internal method which also has effect in the stack trace shim that is reliant on function names on firefox.

[benjamingr]

Thanks.
Can you make a short coding standards document and add it as a .md ?

Also, what's with Promise$_all vs Promise$all? Is that a typo?

[petkaantonov]

Those are different functions with Promise$all being API function and Promise_$all being an internal function.

[petkaantonov]

The name on this function doesn't make sense though that should be changed: https://github.com/petkaantonov/bluebird/blob/master/src/promise.js#L1132-L1163

[benjamingr]

Thanks. Feel free to close this with the commit :)