Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate returns different field names #62

Open
wshager opened this issue Mar 25, 2015 · 6 comments
Open

aggregate returns different field names #62

wshager opened this issue Mar 25, 2015 · 6 comments

Comments

@wshager
Copy link
Contributor

wshager commented Mar 25, 2015

See #61
The test fails because the field is renamed to '0'. This part of the implementation seems to be undocumented.

@wshager
Copy link
Contributor Author

wshager commented Mar 26, 2015

I updated the test to reflect the undocumented feature. I'll leave this open because of the omission in the specification.

@wshager
Copy link
Contributor Author

wshager commented Mar 26, 2015

See #63

@neonstalwart
Copy link
Member

@wshager it seems that the '0' corresponds to the index of the aggregation function. this makes it possible to do multiple aggregations on the same data and extract each result independently.

@wshager
Copy link
Contributor Author

wshager commented Mar 26, 2015

I assume Kris will have to update the specs? Hopefully he can find a minute to do that.

@neonstalwart
Copy link
Member

yeah, you're probably not happy to hear this, but personally i'm not interested in the specs so they won't get any of my time - the code is all the spec i have need for right now. my main concern is keeping this codebase stable. my limited energy will only be invested towards that for now.

@wshager
Copy link
Contributor Author

wshager commented Mar 26, 2015

@neonstalwart thanks no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants