-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use toml-test to generate tests #911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for taking a stab at this!
Tests don't compile because some of them are generated multiple times in
I haven't looked into it but seems like the new way to generate test name isn't unique enough? |
On Thu Oct 26, 2023 at 7:19 PM CEST, Thomas Pelletier wrote:
I haven't looked into it but seems like the new way to generate test name isn't unique enough?
That was also my guess, but I haven't taken a look at the name
generation at all.
…--
Moritz Poldrack
https://moritz.sh
Made with real ingredients.
|
pelletier
reviewed
Oct 26, 2023
mpldr
commented
Oct 26, 2023
pelletier
reviewed
Oct 26, 2023
Add dependency on current HEAD of toml-test, since -copy is not yet released and use it instead of the zip-download to fetch test files. Fixes: #909
Now all issues should be resolved. |
Closed
Looking good! Thank you for taking care of this! |
jooola
referenced
this pull request
in hetznercloud/cli
Dec 12, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pelletier/go-toml/v2](https://togithub.com/pelletier/go-toml) | require | patch | `v2.1.0` -> `v2.1.1` | --- ### Release Notes <details> <summary>pelletier/go-toml (github.com/pelletier/go-toml/v2)</summary> ### [`v2.1.1`](https://togithub.com/pelletier/go-toml/releases/tag/v2.1.1) [Compare Source](https://togithub.com/pelletier/go-toml/compare/v2.1.0...v2.1.1) <!-- Release notes generated using configuration in .github/release.yml at v2.1.1 --> ##### What's Changed ##### Fixed bugs - Fix unmarshaling of nested non-exported struct by [@​pelletier](https://togithub.com/pelletier) in [https://github.com/pelletier/go-toml/pull/917](https://togithub.com/pelletier/go-toml/pull/917) ##### New Contributors - [@​arp242](https://togithub.com/arp242) made their first contribution in [https://github.com/pelletier/go-toml/pull/907](https://togithub.com/pelletier/go-toml/pull/907) - [@​mpldr](https://togithub.com/mpldr) made their first contribution in [https://github.com/pelletier/go-toml/pull/911](https://togithub.com/pelletier/go-toml/pull/911) **Full Changelog**: pelletier/go-toml@v2.1.0...v2.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables using toml-test to generate the testfiles. The tests currently generated fail to compile, but as far as I can tell at 12:40 am this seems not to be caused by me. I at least hope it's something trivial to fix.