-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right single quotation mark in node name causes it to be unsearchable in autocomplete #169
Comments
Is it one of these quotes? The Pelias parser treats those quotes as word boundaries, although there is a code comment below noting that this should only be for quote pairs. |
I'm not sure if this is a data error or a code error, surely 'apostrophe' is the correct character to use?
The same dictionary describes a quotation mark as:
|
Hi, Yes, it is one of the characters in the AFAIK the right single quotation mark can be used in some languages to alter the sound of a letter (a diacritical mark). [Wikipedia](https://en.wikipedia.org/wiki/Right_single_quotation_mark#:~:text=The%20Unicode%20character%20'%20(U%2B,right%20(closing)%20quotation%20mark.) describes a right single quotation mark as:
Both the apostrophe and the right single quotation mark are modifier letters. It is used in Ukrainian language. |
Agh ok, thanks for posting that link, we're definitely in this situation of "difficulty of software distinguishing which character is intended by a user's typing". I don't have the time to work on this right now but I'd be fine with removing it from the quotes array, question is, will that break anything? A more robust solution would involve splitting these quotes into opening/closing pairs and only considering them as word boundaries when both exist in the text, although this may cause issues with autocomplete. |
Describe the bug
When searching via autocomplete for this place (
В’ячеслава Чорновола вулиця 8
), no results are returned. However, reverse geocoding does return the place.In the autocomplete request I see that the parser disregards everything in front of the right single quotation mark(
’
), causing the subject to be8 ячеслава Чорновола вулиця
(street:ячеслава Чорновола вулиця
, housenumber:8
).I have tested with a different place that has apostrophe instead in it's name and it works as expected:
П'ятихатки Вулиця 11
)11 П'ятихатки Вулиця
(street:П'ятихатки Вулиця
, housenumber:11
).Is this a parser issue or the schema is also affected? I see in this file that this character is not included.
Steps to Reproduce
Search for a place that has a
right single quotation mark
in it's name using autocompleteExpected behavior
Expected the place to be returned since it exists in the database.
Environment (please complete the following information):
NA
Pastebin/Screenshots
NA
Additional context
NA
References
NA
The text was updated successfully, but these errors were encountered: