Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create-react-app example #525

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Add create-react-app example #525

merged 3 commits into from
Oct 20, 2020

Conversation

sasoria
Copy link
Contributor

@sasoria sasoria commented Oct 17, 2020

Added a create-react-app example in case anyone is wondering how to use it with actions-gh-pages. It differs slightly from Static Site Generators with Node.js.

@sasoria sasoria requested a review from peaceiris as a code owner October 17, 2020 18:28
@peaceiris
Copy link
Owner

peaceiris commented Oct 18, 2020

There is only a difference of publish_dir between your new section with the Node.js section. Please add the link of create-react-app to the Static Site Generators with Node.js section.

- [hexo], [vuepress], [react-static], [gridsome], and so on.
+ [hexo], [vuepress], [react-static], [gridsome], [create-react-app], and so on.

[hexo]: https://github.com/hexojs/hexo
[vuepress]: https://github.com/vuejs/vuepress
[react-static]: https://github.com/react-static/react-static
[gridsome]: https://github.com/gridsome/gridsome
+ [create-react-app]: https://github.com/facebook/create-react-app

@sasoria
Copy link
Contributor Author

sasoria commented Oct 18, 2020

Thank you for the feedback. I've done as requested and added a comment about publish_dir

Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants