-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two minor changes #610
Merged
Merged
Two minor changes #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like I am being attacked for the f-string by an outdated flake8 or something. (I will fix the whitespace ASAP, but I am currently in a bit of rebase hell of my own making.) |
This does not make is usable, but will satisfy my curiosity.
I can see why the I can also reproduce the Will cleanup both a bit before merging. |
@Artoria2e5 Thanks for noticing and fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two very minor headaches I had when playing with
pdf2txt.py
.-t
value produces a cryptic message. Now it raises a properValueError
.-t tag
produces a runtime error. Now it runs correctly (as in, it successfully produces incomprehensible garbage that hasn't been run through layout analysis:))Checklist
works
is not necessary
verified that this is not necessary
CHANGELOG.md