Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track internal clicked state of response actions #362

Closed
rebeccaalpert opened this issue Dec 9, 2024 · 1 comment · Fixed by #382
Closed

Track internal clicked state of response actions #362

rebeccaalpert opened this issue Dec 9, 2024 · 1 comment · Fixed by #382
Assignees
Labels
PF6 Applies to only the PF6 version
Milestone

Comments

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Dec 9, 2024

Do something like this: https://github.com/patternfly/patternfly-react/blob/main/packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx#L453 to make it easier for consumers to update aria-labels, tooltips, etc. (or update it for them).

Also include a design update (called out by @pilhuhn) to make it easier to notice the state. Kayla just worked on a quick state change design.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Dec 9, 2024
@rebeccaalpert rebeccaalpert added the PF6 Applies to only the PF6 version label Dec 9, 2024
@rebeccaalpert rebeccaalpert added this to the 2025.Q1 milestone Dec 9, 2024
@kaylachumley
Copy link

Image

added a clicked state for the response actions

background token: pf-t--global--background--color--action--plain--clicked
icon fill token: pf-t--global--icon--color--regular

@rebeccaalpert rebeccaalpert linked a pull request Dec 12, 2024 that will close this issue
@rebeccaalpert rebeccaalpert modified the milestones: 2025.Q1, 2024.Q4 Dec 13, 2024
@rebeccaalpert rebeccaalpert moved this from Needs triage to PR Review in PatternFly Issues Dec 13, 2024
@rebeccaalpert rebeccaalpert self-assigned this Dec 13, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF6 Applies to only the PF6 version
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants