Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y - Remove unnecessary aria-describedbys #218

Closed
rebeccaalpert opened this issue Oct 11, 2024 · 0 comments · Fixed by #243
Closed

a11y - Remove unnecessary aria-describedbys #218

rebeccaalpert opened this issue Oct 11, 2024 · 0 comments · Fixed by #243
Assignees
Labels
A11y PF Team PF6 Applies to only the PF6 version

Comments

@rebeccaalpert
Copy link
Member

A majority of buttons look to have both an aria-describedby and aria-label, where the aria-describedby is unnecessary/adding noise/pointing to a tooltip that contains the same content as the aria-label. Instead the aria-describedby should be removed from these buttons (the content being pointed to isn't really "describing" the button as much as it is labeling it) and either update the aria-label to match the tooltip content or use aria-labelledby instead

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 11, 2024
@rebeccaalpert rebeccaalpert added bug PF6 Applies to only the PF6 version labels Oct 11, 2024
@rebeccaalpert rebeccaalpert self-assigned this Oct 11, 2024
@rebeccaalpert rebeccaalpert moved this from Needs triage to Not started in PatternFly Issues Oct 11, 2024
@nicolethoen nicolethoen linked a pull request Oct 14, 2024 that will close this issue
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues Oct 14, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y PF Team PF6 Applies to only the PF6 version
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants