Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to customize the frontend #67

Closed
3 tasks done
bmuenzenmeyer opened this issue Aug 10, 2017 · 4 comments
Closed
3 tasks done

Make it easier to customize the frontend #67

bmuenzenmeyer opened this issue Aug 10, 2017 · 4 comments
Assignees
Milestone

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Aug 10, 2017

A bucket of ideas, which may become their own issues in respective repositories, or spec issues:

  • Allow users to provide override templates at build time
  • Allow users to provide their own CSS at build time
  • Do not minify assets by default
@bmuenzenmeyer bmuenzenmeyer added this to the vNext milestone Aug 10, 2017
@bradfrost
Copy link
Member

Issue #72 would affect and/or address some of these things.

@bradfrost
Copy link
Member

I removed minification of the CSS and renamed to pattern-lab.css to make it clearer what the file does: a89f621

@bradfrost
Copy link
Member

With #72 more or less done, I think these items are addressed. I'm not exactly sure if that includes "Allow users to provide override templates at build time", but I'm going to close this out and we can discuss in a dedicated new issue if that still isn't addressed.

@bmuenzenmeyer
Copy link
Member Author

I'm not exactly sure if that includes "Allow users to provide override templates at build time", but I'm going to close this out and we can discuss in a dedicated new issue if that still isn't addressed.

basically, allow someone to do this inside patternlab-config.json pattern-lab/patternlab-node#683 - circumventing the need to fork this repo for simple markup changes (especially if we support a custom CSS file via the theme object

@bmuenzenmeyer bmuenzenmeyer self-assigned this Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants