Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for PostGIS 3.5 #9354

Merged
merged 3 commits into from
Oct 22, 2024
Merged

feat: Add support for PostGIS 3.5 #9354

merged 3 commits into from
Oct 22, 2024

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 21, 2024 •
edited
Loading

Pull Request

Issue

A new version of Postgis was recently released. Currently not testing against.

Closes: #9355

Approach

Tasks

  • Ensure test suite passes

@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Oct 21, 2024 •
edited
Loading

Thanks for opening this pull request!

@dplewis
Copy link
Member

dplewis commented Oct 21, 2024

@cbaker6 should the scripts be updated? Would the extensions always install the latest?

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (dfd5a8e) to head (49164ec).
Report is 2 commits behind head on alpha.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #9354   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         186      186           
  Lines       14811    14811           
=======================================
  Hits        13846    13846           
  Misses        965      965

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 22, 2024 •
edited
Loading

@cbaker6 should the scripts be updated? Would the extensions always install the latest?

The scripts here? https://github.com/parse-community/parse-server/tree/alpha/scripts They should always install the latest extensions available on the respective container (extensions were installed on the image via apt-get), so we should be good there.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 22, 2024

@mtrezza this is ready for review

mtrezza
mtrezza approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for CI to pass...

@mtrezza mtrezza changed the title feat: Add support for Postgis 3.5 feat: Add support for PostGIS 3.5 Oct 22, 2024
@mtrezza mtrezza merged commit 8ea3538 into parse-community:alpha Oct 22, 2024
30 checks passed
parseplatformorg pushed a commit that referenced this pull request Oct 22, 2024
@semantic-release-bot
chore(release): 7.4.0-alpha.3 [skip ci]
5e1546e 
# [7.4.0-alpha.3](7.4.0-alpha.2...7.4.0-alpha.3) (2024-10-22)

### Features

* Add support for PostGIS 3.5 ([#9354](#9354)) ([8ea3538](8ea3538))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.4.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 22, 2024
@cbaker6 cbaker6 deleted the cbaker6-patch-1 branch October 22, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released-alpha Released as alpha version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade CI to test against Postgis 3.5
4 participants
@cbaker6 @dplewis @parseplatformorg @mtrezza