feat: Add atomic operations for Cloud Config parameters #9219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
dplewis
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9219 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 186 186
Lines 14762 14762
=======================================
Hits 13797 13797
Misses 965 965 ☔ View full report in Codecov by Sentry. |
|
Does that mean atomic operations were already working? |
They cause an internal server error |
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 18, 2024
# [7.3.0-alpha.4](7.3.0-alpha.3...7.3.0-alpha.4) (2024-07-18) ### Features * Add atomic operations for Cloud Config parameters ([#9219](#9219)) ([35cadf9](35cadf9))
|
🎉 This change has been released in version 7.3.0-alpha.4 |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 3, 2024
# [7.3.0-beta.1](7.2.0...7.3.0-beta.1) (2024-10-03) ### Bug Fixes * Custom object ID allows to acquire role privileges ([GHSA-8xq9-g7ch-35hg](GHSA-8xq9-g7ch-35hg)) ([#9317](#9317)) ([13ee52f](13ee52f)) * Parse Server `databaseOptions` nested keys incorrectly identified as invalid ([#9213](#9213)) ([77206d8](77206d8)) * Parse Server installation fails due to post install script incorrectly parsing required min. Node version ([#9216](#9216)) ([0fa82a5](0fa82a5)) * Parse Server option `maxLogFiles` doesn't recognize day duration literals such as `1d` to mean 1 day ([#9215](#9215)) ([0319cee](0319cee)) * Security upgrade path-to-regexp from 6.2.1 to 6.3.0 ([#9314](#9314)) ([8b7fe69](8b7fe69)) ### Features * Add atomic operations for Cloud Config parameters ([#9219](#9219)) ([35cadf9](35cadf9)) * Add Cloud Code triggers `Parse.Cloud.beforeSave` and `Parse.Cloud.afterSave` for Parse Config ([#9232](#9232)) ([90a1e4a](90a1e4a)) * Add Node 22 support ([#9187](#9187)) ([7778471](7778471)) * Add support for asynchronous invocation of `FilesAdapter.getFileLocation` ([#9271](#9271)) ([1a2da40](1a2da40))
|
🎉 This change has been released in version 7.3.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 3, 2024
# [7.3.0](7.2.0...7.3.0) (2024-10-03) ### Bug Fixes * Custom object ID allows to acquire role privileges ([GHSA-8xq9-g7ch-35hg](GHSA-8xq9-g7ch-35hg)) ([#9317](#9317)) ([13ee52f](13ee52f)) * Parse Server `databaseOptions` nested keys incorrectly identified as invalid ([#9213](#9213)) ([77206d8](77206d8)) * Parse Server installation fails due to post install script incorrectly parsing required min. Node version ([#9216](#9216)) ([0fa82a5](0fa82a5)) * Parse Server option `maxLogFiles` doesn't recognize day duration literals such as `1d` to mean 1 day ([#9215](#9215)) ([0319cee](0319cee)) * Security upgrade path-to-regexp from 6.2.1 to 6.3.0 ([#9314](#9314)) ([8b7fe69](8b7fe69)) ### Features * Add atomic operations for Cloud Config parameters ([#9219](#9219)) ([35cadf9](35cadf9)) * Add Cloud Code triggers `Parse.Cloud.beforeSave` and `Parse.Cloud.afterSave` for Parse Config ([#9232](#9232)) ([90a1e4a](90a1e4a)) * Add Node 22 support ([#9187](#9187)) ([7778471](7778471)) * Add support for asynchronous invocation of `FilesAdapter.getFileLocation` ([#9271](#9271)) ([1a2da40](1a2da40))
|
🎉 This change has been released in version 7.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Atomic operations aren't supported for Cloud Config
Closes: #8649
Approach
Skip sanitization of db results since it can't handle dot notation on atomic operations when using upsert. We aren't returning the results to the client anyway so it can be skipped.
Cloud Config uses dot notation to save data. Postgres only supports increment on dot notation currently.