Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TOTP adaper to return strings #8660

Closed
3 tasks done
dblythy opened this issue Jun 25, 2023 · 5 comments · Fixed by #8661
Closed
3 tasks done

Refactor TOTP adaper to return strings #8660

dblythy opened this issue Jun 25, 2023 · 5 comments · Fixed by #8661
Labels
block:beta Needs to be resolved before next release on beta branch; remove label afterwards state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@dblythy
Copy link
Member

dblythy commented Jun 25, 2023

New Feature / Enhancement Checklist

Current Limitation

As discussed in #8457, mixed return types for the TOTP adapter makes it incompatible with certain client SDKs

Feature / Enhancement Description

Refactor adapter to return strings

Example Use Case

Alternatives / Workarounds

3rd Party References
@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@dblythy dblythy mentioned this issue Jun 25, 2023
Merged
2 tasks
@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Jun 25, 2023
@mtrezza mtrezza added the block:beta Needs to be resolved before next release on beta branch; remove label afterwards label Jul 4, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.6

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 17, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block:beta Needs to be resolved before next release on beta branch; remove label afterwards state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Change response types of TOTP adapter to match existing adapters dblythy/parse-server
3 participants
@dblythy @mtrezza @parseplatformorg