-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI should run against latest Postgres versions #8192
Comments
Thanks for opening this issue!
|
Removing support for a database or node major version is a breaking change, which we'll do with Parse Server 6. So it makes more sense to separate this PR into:
Btw, MongoDB and Node.js patch versions are updated automatically with a script that detects whether there is a newer version available. It would be good if someone could extend that script to include Postgres. |
For the PR, I didn't remove any code in the repo or tests, so the code to handle those versions is untouched. They are simply not tested in the CI anymore in the PR. This allows developers to manually test on old versions that have reached Parse Server EOL if they want until someone decides to remove the code in the future (see discussion here).
The Postgres components of the CI already do patch updates from the way I added them to the CI a long time ago (Minor/patch of Postgres, Minor of Postgis). Minor versions of Postgis need to be bumped manually. See the original comment in the approach section of #7176 for more |
We don't operate like that. A versions is officially supported by Parse Platform as long as it's tested in the CI and vice versa.
What about this change in your PR: - name: PostgreSQL 14, PostGIS 3.2
- POSTGRES_IMAGE: postgis/postgis:14-3.2
+ name: PostgreSQL 14, PostGIS 3.3
+ POSTGRES_IMAGE: postgis/postgis:14-3.3 |
The sermver states:
Therefore what I stated earlier holds:
|
If this is the case, I recommend coming up with a better way to describe EOL in the README. It's currently based on dates: which is not what your comment above states. Maybe is should be based on Parse-Server |
Right, I overlooked that. Extending the script we use for MongoDB and Node would still be nice, it also notifies about new major / minor versions available.
The wording is from before we introduced calver versioning. Now we could simplify this to:
According to that, Postgres 11 should already have been unsupported from Parse Server 5. The first release date of PG 11 was October 18, 2018, so we would have supported it for >3 years. PG 12 was released October 3, 2019, so the newer version was available for >2 years before we would have dropped support. Essentially we give developers 2.25 years to upgrade to the next PG version. Compared to MongoDB, they give developers ~2.5-2.75 years to migrate to the next higher version. That means in 3 months (Parse Server 6) we'll drop support for Postgres 11 and 12, but it will stay supported in our LTS branch for an additional year until end of 2023. Does this make sense? |
🎉 This change has been released in version 5.3.0-alpha.27 |
🎉 This change has been released in version 5.4.0-beta.1 |
🎉 This change has been released in version 5.4.0-alpha.1 |
🎉 This change has been released in version 5.4.0 |
🎉 This change has been released in version 5.4.0 |
New Feature / Enhancement Checklist
Current Limitation
The CI isn't testing against the current latest versions of dependencies (e.g. Postgis 3.3) and still testing against dependencies that has reached the Parse EOL. This prevents the CI from determining if there are issues with the latest versions along with running unnecessary tests for each PR.
Feature / Enhancement Description
Update versions of Postgis, remove versions that have reached EOL: Postres 11, Postgis 3.0, Node 12, Mongo 4.0, Mongo MMAPv1.
Example Use Case
N/A
Alternatives / Workarounds
Test latest versions on our own.
3rd Party References
N/A
The text was updated successfully, but these errors were encountered: