fix: Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object #1453

mstniy · 2022-02-16T10:54:35Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Fix #1452

Related issue: #1452

Approach

ParseObject.toJSON() no longer applies pending operations a second time. attributes takes care of them already.

TODOs before merging

Add tests
Add entry to changelog
Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant · 2022-02-16T10:54:38Z

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

mtrezza · 2022-02-16T22:53:43Z

To fix the commit message check, could you please change the title to fix: <summary of bug>.

dplewis · 2024-05-02T15:10:15Z

@mstniy @mtrezza I think #1451 also fixes this issue. Can you have a look? I can't seem to get duplicate pending operations to appear with this new fix in place.

mstniy · 2024-05-02T15:22:57Z

@dplewis Strange that you cannot replicate it. I tested it with #1451 and the issue was still there.

Did you follow the steps in #1452?

dplewis · 2024-05-02T20:10:34Z

@mstniy Ok this looks good. Can you add the following integration test?

it('can set nested fields without repeating pending operations on toJSON', async () => {
    const a = new Parse.Object("MyObject");
    a.set('obj', {});
    await a.save();
    a.set('obj.a', 0);
    const json = a.toJSON();
    expect(json.obj).toEqual({ a: 0 });
    expect(json['obj.a']).toBeUndefined();
  });

…e in ParseObject.toJSON()

parse-github-assistant · 2024-05-02T21:09:10Z

I will reformat the title to use the proper commit message syntax.

mstniy · 2024-05-02T21:09:41Z

@dplewis Added the test with small modifications

codecov · 2024-05-02T21:14:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72bc9ac) to head (21bcaae).
Report is 17 commits behind head on alpha.

Additional details and impacted files

@@             Coverage Diff             @@
##            alpha     #1453      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files          61        64       +3     
  Lines        6185      6205      +20     
  Branches     1499      1504       +5     
===========================================
+ Hits         6184      6205      +21     
+ Misses          1         0       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dplewis

LGTM!

# [5.1.0-alpha.8](5.1.0-alpha.7...5.1.0-alpha.8) (2024-05-02) ### Bug Fixes * Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object ([#1453](#1453)) ([23cc573](23cc573))

parseplatformorg · 2024-05-02T23:13:31Z

🎉 This change has been released in version 5.1.0-alpha.8

# [5.1.0-beta.1](5.0.0...5.1.0-beta.1) (2024-05-16) ### Bug Fixes * `Parse.GeoPoint.current` returns `undefined` ([#2127](#2127)) ([3860535](3860535)) * Chrome browser console warning about unsafe header `access-control-expose-headers` when calling Cloud Function ([#2095](#2095)) ([7b73c03](7b73c03)) * Live Query not working on Expo React Native ([#2109](#2109)) ([7a89665](7a89665)) * Local datastore throws error when `Parse.Query.notEqualTo` is set to `null` ([#2102](#2102)) ([6afd32a](6afd32a)) * Multiple object updates of nested keys overwrite each other ([#1451](#1451)) ([fa4341a](fa4341a)) * Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object ([#1453](#1453)) ([23cc573](23cc573)) * Remove circular dependencies ([#2125](#2125)) ([b415165](b415165)) ### Features * Add password validation for user with unverified email via `Parse.User.verifyPassword` using master key and option `ignoreEmailVerification: true` ([#2076](#2076)) ([b0adf7e](b0adf7e)) * Add support for setting `Parse.ACL` from json ([#2097](#2097)) ([72bc9ac](72bc9ac)) * Allow setting custom queue for handling offline operations via `Parse.EventuallyQueue` ([#2106](#2106)) ([f92e4d4](f92e4d4)) * Improve installation object `Parse.Installation.currentInstallation` to support web push notifications ([#2119](#2119)) ([4fc62ce](4fc62ce)) * Lazy load `Parse.CoreManager` controllers to add support for swappable `CryptoController`, `LocalDatastoreController`, `StorageController`, `WebSocketController`, `ParseLiveQuery` ([#2100](#2100)) ([fbd0ab1](fbd0ab1))

parseplatformorg · 2024-05-16T12:26:54Z

🎉 This change has been released in version 5.1.0-beta.1

# [5.1.0](5.0.0...5.1.0) (2024-05-16) ### Bug Fixes * `Parse.GeoPoint.current` returns `undefined` ([#2127](#2127)) ([3860535](3860535)) * Chrome browser console warning about unsafe header `access-control-expose-headers` when calling Cloud Function ([#2095](#2095)) ([7b73c03](7b73c03)) * Live Query not working on Expo React Native ([#2109](#2109)) ([7a89665](7a89665)) * Local datastore throws error when `Parse.Query.notEqualTo` is set to `null` ([#2102](#2102)) ([6afd32a](6afd32a)) * Multiple object updates of nested keys overwrite each other ([#1451](#1451)) ([fa4341a](fa4341a)) * Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object ([#1453](#1453)) ([23cc573](23cc573)) * Remove circular dependencies ([#2125](#2125)) ([b415165](b415165)) ### Features * Add password validation for user with unverified email via `Parse.User.verifyPassword` using master key and option `ignoreEmailVerification: true` ([#2076](#2076)) ([b0adf7e](b0adf7e)) * Add support for setting `Parse.ACL` from json ([#2097](#2097)) ([72bc9ac](72bc9ac)) * Allow setting custom queue for handling offline operations via `Parse.EventuallyQueue` ([#2106](#2106)) ([f92e4d4](f92e4d4)) * Improve installation object `Parse.Installation.currentInstallation` to support web push notifications ([#2119](#2119)) ([4fc62ce](4fc62ce)) * Lazy load `Parse.CoreManager` controllers to add support for swappable `CryptoController`, `LocalDatastoreController`, `StorageController`, `WebSocketController`, `ParseLiveQuery` ([#2100](#2100)) ([fbd0ab1](fbd0ab1))

parseplatformorg · 2024-05-16T13:23:40Z

🎉 This change has been released in version 5.1.0

mstniy changed the title ~~Fix #1452~~ fix: toJSON() repeats pending updates to nested keys Feb 16, 2022

mstniy added 3 commits May 2, 2024 23:01

Expanded an existing test to reproduce parse-community#1452

5e36120

Fix parse-community#1452 by not applying pending updates a second tim…

1ae6b29

…e in ParseObject.toJSON()

Added new integration test

21bcaae

mstniy force-pushed the nested_tojson_1452 branch from ec75ddb to 21bcaae Compare May 2, 2024 21:09

parse-github-assistant bot changed the title ~~fix: toJSON() repeats pending updates to nested keys~~ fix: ToJSON() repeats pending updates to nested keys May 2, 2024

dplewis requested a review from a team May 2, 2024 21:54

dplewis approved these changes May 2, 2024

View reviewed changes

mtrezza changed the title ~~fix: ToJSON() repeats pending updates to nested keys~~ fix: Pending updates to nested fields cause ParseObject.toJSON() to return incorrect object May 2, 2024

mtrezza changed the title ~~fix: Pending updates to nested fields cause ParseObject.toJSON() to return incorrect object~~ fix: Pending updates to nested field causes ParseObject.toJSON() to return incorrect object May 2, 2024

mtrezza approved these changes May 2, 2024

View reviewed changes

mtrezza merged commit 23cc573 into parse-community:alpha May 2, 2024
10 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label May 2, 2024

mstniy deleted the nested_tojson_1452 branch May 2, 2024 23:18

parseplatformorg added the state:released-beta Released as beta version label May 16, 2024

parseplatformorg added the state:released Released as stable version label May 16, 2024

This was referenced Jun 6, 2024

feat: Upgrade to Parse JS SDK 5.2.0 parse-community/parse-server#9128

Merged

fix: Duplicate pending operations on nested fields #2162

Merged

parseplatformorg mentioned this pull request Jun 6, 2024

refactor: Upgrade parse from 5.0.0 to 5.1.0 parse-community/parse-server-push-adapter#252

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object #1453

fix: Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object #1453

mstniy commented Feb 16, 2022 •

edited

Loading

parse-github-assistant bot commented Feb 16, 2022 •

edited

Loading

mtrezza commented Feb 16, 2022

dplewis commented May 2, 2024 •

edited

Loading

mstniy commented May 2, 2024

dplewis commented May 2, 2024 •

edited

Loading

parse-github-assistant bot commented May 2, 2024

mstniy commented May 2, 2024

codecov bot commented May 2, 2024

dplewis left a comment

parseplatformorg commented May 2, 2024

parseplatformorg commented May 16, 2024

parseplatformorg commented May 16, 2024

fix: Pending updates to nested field causes ParseObject.toJSON() to return incorrect object #1453

fix: Pending updates to nested field causes ParseObject.toJSON() to return incorrect object #1453

Conversation

mstniy commented Feb 16, 2022 • edited Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Feb 16, 2022 • edited Loading

Thanks for opening this pull request!

mtrezza commented Feb 16, 2022

dplewis commented May 2, 2024 • edited Loading

mstniy commented May 2, 2024

dplewis commented May 2, 2024 • edited Loading

parse-github-assistant bot commented May 2, 2024

mstniy commented May 2, 2024

codecov bot commented May 2, 2024

Codecov Report

dplewis left a comment

Choose a reason for hiding this comment

parseplatformorg commented May 2, 2024

parseplatformorg commented May 16, 2024

parseplatformorg commented May 16, 2024

fix: Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object #1453

fix: Pending updates to nested field causes `ParseObject.toJSON()` to return incorrect object #1453

mstniy commented Feb 16, 2022 •

edited

Loading

parse-github-assistant bot commented Feb 16, 2022 •

edited

Loading

dplewis commented May 2, 2024 •

edited

Loading

dplewis commented May 2, 2024 •

edited

Loading