Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Facebook SDK 15.x #1188

Conversation

cjosepha
Copy link
Contributor

@cjosepha cjosepha commented Feb 20, 2023

New Pull Request Checklist

Issue Description

Use more recent version of Facebook SDK to fix an issue where the login flow is broken if the Facebook app is not installed on the device. See Facebook SDK v14.1.1 changelog: https://github.com/facebook/facebook-android-sdk/blob/main/CHANGELOG.md#1411

Closes: #1187

Approach

Allow to use Facebook SDK dependency v14.1.1

TODOs before merging

Nothing necessary

…login flow is broken if the Facebook app is not installed on the device. See Facebook SDK v14.1.1 changelog: https://github.com/facebook/facebook-android-sdk/blob/main/CHANGELOG.md#1411
@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 20, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (6a28076) compared to base (2756d05).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1188   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         122     122           
  Lines        9971    9971           
  Branches     1345    1345           
======================================
  Misses       9971    9971           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

facebook/build.gradle Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title Use more recent version of Facebook SDK to fix login flow issue feat: Upgrade to Facebook SDK 15 Feb 21, 2023
@mtrezza mtrezza changed the title feat: Upgrade to Facebook SDK 15 feat: Upgrade to Facebook SDK 15.x Feb 21, 2023
@mtrezza mtrezza changed the title feat: Upgrade to Facebook SDK 15.x feat: Support Facebook SDK 15.x Feb 21, 2023
@mtrezza mtrezza changed the title feat: Support Facebook SDK 15.x feat: Add support for Facebook SDK 15.x Feb 21, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 5ebd443 into parse-community:master Feb 22, 2023
parseplatformorg pushed a commit that referenced this pull request Feb 22, 2023
# [4.2.0](4.1.0...4.2.0) (2023-02-22)

### Features

* Add support for Facebook SDK 15.x ([#1188](#1188)) ([5ebd443](5ebd443))
@parseplatformorg
Copy link

🎉 This change has been released in version 4.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facebook Login not working when Facebook app is not installed
3 participants