-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Facebook SDK 15.x #1188
feat: Add support for Facebook SDK 15.x #1188
Conversation
…login flow is broken if the Facebook app is not installed on the device. See Facebook SDK v14.1.1 changelog: https://github.com/facebook/facebook-android-sdk/blob/main/CHANGELOG.md#1411
Thanks for opening this pull request!
|
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 122 122
Lines 9971 9971
Branches 1345 1345
======================================
Misses 9971 9971 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
# [4.2.0](4.1.0...4.2.0) (2023-02-22) ### Features * Add support for Facebook SDK 15.x ([#1188](#1188)) ([5ebd443](5ebd443))
🎉 This change has been released in version 4.2.0 |
New Pull Request Checklist
Issue Description
Use more recent version of Facebook SDK to fix an issue where the login flow is broken if the Facebook app is not installed on the device. See Facebook SDK v14.1.1 changelog: https://github.com/facebook/facebook-android-sdk/blob/main/CHANGELOG.md#1411
Closes: #1187
Approach
Allow to use Facebook SDK dependency v14.1.1
TODOs before merging
Nothing necessary