Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade various dependencies #1181

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Conversation

xareal
Copy link
Contributor

@xareal xareal commented Aug 25, 2022

New Pull Request Checklist

Issue Description

Newer versions were available.

Related issue: #n/a

Approach

I just updated the dependencies.

  • Kotlin,

  • facebook login,

  • firebase messaging,

  • android.gms:play-services-auth,

  • fragments,

  • activity-ktx,

  • annotation,

  • okhttp,

  • appcompact

  • Add tests

  • Add changes to documentation (guides, repository pages, in-code descriptions)

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

Kotlin, facebook login, firebase messaging, android.gms:play-services-auth, fragments, activity-ktx, annotation, okhttp, appcompact updated.
@parse-github-assistant
Copy link

parse-github-assistant bot commented Aug 25, 2022

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

facebook/build.gradle Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the FB range, and the PR title, see the failing commit message check, otherwise looks good.

@mtrezza
Copy link
Member

mtrezza commented Aug 25, 2022

The current version of the Facebook SDK for Android is version 14.1.0 and requires the Android API 15.

If you want to also upgrade the FB SDK, then I'd do that in a separate PR. As we've seen in the past, since it's a transitive dependency it may require some more deliberation. It's also considered a breaking change, so it would bump the Parse SDK to 5.x and we should probably bump all other dependencies as courtesy first with this PR.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1181 (56bcb02) into master (44b1914) will not change coverage.
The diff coverage is n/a.

❗ Current head 56bcb02 differs from pull request most recent head fd1d602. Consider uploading reports for the commit fd1d602 to get more accurate results

@@          Coverage Diff           @@
##           master   #1181   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         122     122           
  Lines        9971    9971           
  Branches     1345    1345           
======================================
  Misses       9971    9971           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mtrezza mtrezza changed the title Dependencies updated. feat: upgrade various dependencies Aug 26, 2022
facebook/build.gradle Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I fixed the commit message (PR title) and reverted the FB lib range.
Is this ready for merge?

@mtrezza mtrezza merged commit c455f4a into parse-community:master Aug 26, 2022
parseplatformorg pushed a commit that referenced this pull request Aug 26, 2022
# [4.1.0](4.0.0...4.1.0) (2022-08-26)

### Bug Fixes

* exception on concurrent download of `ParseFile` from multiple threads ([#1180](#1180)) ([44b1914](44b1914))

### Features

* upgrade various dependencies ([#1181](#1181)) ([c455f4a](c455f4a))
@parseplatformorg
Copy link

🎉 This change has been released in version 4.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Aug 26, 2022
@xareal
Copy link
Contributor Author

xareal commented Aug 26, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants