fix: failed signup attempt with anonymous ParseUser leaves it in inconsistent state #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
|
@shlusiak can you check please the failing test |
|
@L3K0V I think I fixed the failing test. Let's see if it passes now. |
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
============================================
- Coverage 65.31% 65.30% -0.02%
+ Complexity 2219 2218 -1
============================================
Files 122 122
Lines 9961 9961
Branches 1338 1338
============================================
- Hits 6506 6505 -1
Misses 2943 2943
- Partials 512 513 +1
Continue to review full report at Codecov.
|
|
@mtrezza LGTM |
mtrezza
changed the title
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 10, 2021
## [2.0.5](2.0.4...2.0.5) (2021-11-10) ### Bug Fixes * failed signup attempt with anonymous ParseUser leaves it in inconsistent state ([#1136](#1136)) ([ac6d9e0](ac6d9e0))
|
🎉 This change has been released in version 2.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
The key "authData" contains a
Mapof authentication related data. Because unfortunatelyestimatedDatais a shallow copy ofstate, the object pointed to bystate["authData"]andestimatedData["authData"]is the same object. Modifying the data in this map directly prevents us from being able to callrevert()to revert the data back to the server state.This is impotant e.g. when trying to revert the user after converting it from anonymous to registered fails, where anonymity has been stripped and there is no way to get it back.
Related issue: #401
Approach
This would just create another (shallow) copy of "authData", which in this case would be fine, because we are only modifying the first layer. By replacing the value of the map with a new map we ensure that the values in
stateandestimatedDataare different and thatrevert()works.