Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Key storage proof v2 #12843

Closed
wants to merge 3 commits into from
Closed

Key storage proof v2 #12843

wants to merge 3 commits into from

Conversation

cheme
Copy link
Contributor

@cheme cheme commented Dec 5, 2022

This PR adds light client call as describe in #10623 .

I only diverge from proposed spec at w3f/polkadot-spec#590 by renaming required bytes hash = 1; in child trie description to required bytes name = 1; : so it is the same as the former storage_key but without prefixing.

Using child trie root hash sounds like a good idea but is not consistent with specifying a block number in the request.

When writing it I also did wonder if we should allow doing the query on multiple child trie (would be a bit of change in the format but pretty ok).

I also did remove the storage cache from the source (should have been removed already I think).

@cheme cheme added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Dec 5, 2022
@bkchr
Copy link
Member

bkchr commented Dec 7, 2022

I also did remove the storage cache from the source (should have been removed already I think).

Yes, looks like some bad merge brought it back.

@stale
Copy link

stale bot commented Jan 6, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 6, 2023
@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 11, 2023
@cheme
Copy link
Contributor Author

cheme commented Jan 11, 2023

not stale.

@stale
Copy link

stale bot commented Feb 10, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Feb 10, 2023
@cheme
Copy link
Contributor Author

cheme commented Feb 11, 2023

not stale

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Feb 11, 2023
@tomaka
Copy link
Contributor

tomaka commented Feb 21, 2023 •
edited
Loading

Opened w3f/PPPs#5

I've added a includeDescendants field for keys, for which the server must also include the list of all children of that key.
This is important in order to implement for example state_getKeys on a light client.

@tomaka tomaka mentioned this pull request Feb 21, 2023
Open
@stale
Copy link

stale bot commented Mar 24, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Mar 24, 2023
@stale stale bot removed the A3-stale label Mar 24, 2023
@cheme cheme added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Mar 27, 2023
@cheme
Copy link
Contributor Author

cheme commented Mar 27, 2023

Switched to "In Progress", as I will also integrate proposed changes from w3f/PPPs#5 (prefix range query, restart and possibly ordering of keys).

@stale
Copy link

stale bot commented Apr 26, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Apr 26, 2023
@cheme
Copy link
Contributor Author

cheme commented Apr 26, 2023

Will open a new one with things for w3f/PPPs#5

@cheme cheme closed this Apr 26, 2023
@tomaka tomaka mentioned this pull request May 25, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. A3-stale B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheme @bkchr @tomaka